Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add telemetry tracer/metric enable flag and integ test #10676

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a36ab39 from #10395.

* Add telemetry tracer/metric enable flag and integ test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add Changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add component flag to traceable wrappers

Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
(cherry picked from commit a36ab39)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 7dbcd6b
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 7dbcd6b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 7dbcd6b
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 7dbcd6b
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testTrackerData

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #10676 (7dbcd6b) into 2.x (e611185) will decrease coverage by 0.17%.
Report is 5 commits behind head on 2.x.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                2.x   #10676      +/-   ##
============================================
- Coverage     70.93%   70.76%   -0.17%     
+ Complexity    58575    58477      -98     
============================================
  Files          4830     4830              
  Lines        276453   276487      +34     
  Branches      40588    40591       +3     
============================================
- Hits         196091   195649     -442     
- Misses        63676    64191     +515     
+ Partials      16686    16647      -39     
Files Coverage Δ
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <100.00%> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java 87.50% <100.00%> (+1.78%) ⬆️
...ch/repositories/gcs/GoogleCloudStorageService.java 82.43% <100.00%> (ø)
...search/telemetry/metrics/OTelMetricsTelemetry.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/tracing/OTelTelemetry.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelTracingTelemetry.java 95.83% <100.00%> (+0.37%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <100.00%> (ø)
...va/org/opensearch/telemetry/TelemetrySettings.java 90.90% <100.00%> (+3.40%) ⬆️
...rg/opensearch/telemetry/tracing/WrappedTracer.java 78.57% <100.00%> (+1.64%) ⬆️
...lemetry/tracing/channels/TraceableHttpChannel.java 54.54% <100.00%> (ø)
... and 7 more

... and 463 files with indirect coverage changes

@reta reta merged commit 1970085 into 2.x Oct 18, 2023
64 checks passed
@github-actions github-actions bot deleted the backport/backport-10395-to-2.x branch October 18, 2023 11:41
@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant