Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PURIFY] Remove DataStreams #40

Closed
tlfeng opened this issue Feb 3, 2021 · 3 comments
Closed

[PURIFY] Remove DataStreams #40

tlfeng opened this issue Feb 3, 2021 · 3 comments
Labels
>FORK Related to the fork process :xpack-removal Related to removal of x-pack

Comments

@tlfeng
Copy link
Collaborator

tlfeng commented Feb 3, 2021

Remove "Data Steams" codes, according to the discussion in PR #36

Basically revert the PRs: #28 #37

@tlfeng tlfeng added :xpack-removal Related to removal of x-pack >FORK Related to the fork process labels Feb 3, 2021
@tlfeng tlfeng changed the title Remove ILM from DataStreams Remove DataStreams Feb 4, 2021
@tlfeng
Copy link
Collaborator Author

tlfeng commented Feb 4, 2021

A sub issue, should be resolved after cleanup for DataStreams:

Remove codes related to "Index Lifecycle Management" altogether from "DataStreams" classes.

ILM codes were removed in the PR #20, but some leftover were introduced by bring back DataStream in th PR #28

As far as I can see, there are a bunch of codes about ilmPolicy in DataStream and GetDataStreamAction classes.

The test failure should be disappear after the issue is resolved.

REPRODUCE WITH: ./gradlew ':client:rest-high-level:test' --tests "org.elasticsearch.client.indices.GetDataStreamResponseTests.testFromXContent" -Dtests.seed=5E1553B2DED480C5 -Dtests.security.manager=true -Dtests.locale=es-AR -Dtests.timezone=America/Punta_Arenas -Druntime.java=15

org.elasticsearch.client.indices.GetDataStreamResponseTests > testFromXContent FAILED
    org.elasticsearch.common.xcontent.XContentParseException: [1:8288] [data_stream] unknown field [ilm_policy]
        at __randomizedtesting.SeedInfo.seed([5E1553B2DED480C5:7F7D66AA5773601F]:0)
        at org.elasticsearch.common.xcontent.ObjectParser.lambda$errorOnUnknown$2(ObjectParser.java:102)
        at org.elasticsearch.common.xcontent.ObjectParser.parse(ObjectParser.java:297)
        at org.elasticsearch.common.xcontent.ConstructingObjectParser.parse(ConstructingObjectParser.java:171)
        at org.elasticsearch.client.indices.DataStream.fromXContent(DataStream.java:116)
        at org.elasticsearch.client.indices.GetDataStreamResponse.fromXContent(GetDataStreamResponse.java:48)
        at org.elasticsearch.client.indices.GetDataStreamResponseTests.doParseToClientInstance(GetDataStreamResponseTests.java:75)
        at org.elasticsearch.client.indices.GetDataStreamResponseTests.doParseToClientInstance(GetDataStreamResponseTests.java:42)

@tlfeng tlfeng changed the title Remove DataStreams [PURIFY] Remove DataStreams Feb 5, 2021
@adnapibar
Copy link
Contributor

The test failure is fixed by #63

@adnapibar
Copy link
Contributor

Closing this issue as the tests were fixed by removing the ILM policy field #63 .

ritty27 pushed a commit to ritty27/OpenSearch that referenced this issue May 12, 2024
…t.docs

[7.16][DOCS] Removes duplicated compatibility section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process :xpack-removal Related to removal of x-pack
Projects
None yet
Development

No branches or pull requests

2 participants