Skip to content

Commit

Permalink
fix: flaky test ClusterMetadataManifestTests
Browse files Browse the repository at this point in the history
We're comparing for unequal manifests but randomBoolean() has a high
probability of getting clashed because of a small search-space, making
test flaky. Let's limit randomization here.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
  • Loading branch information
r1walz committed Sep 4, 2023
1 parent d375e4c commit 7cd5355
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void testClusterMetadataManifestSerializationEqualsHashCode() {
builder.nodeId(randomAlphaOfLength(10));
break;
case 6:
builder.committed(randomBoolean());
builder.committed(!manifest.isCommitted());
break;
case 7:
builder.indices(randomUploadedIndexMetadataList());
Expand Down

0 comments on commit 7cd5355

Please sign in to comment.