Add tests

Signed-off-by: Yanlong He <hey.yanlong@gmail.com>
opensearch-project · Dec 12, 2023 · 401de0b · 401de0b
1 parent 6a68a0f
commit 401de0b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugins/discovery-ec2/src/main/java/org/opensearch/discovery/ec2/AwsEc2ServiceImpl.java b/plugins/discovery-ec2/src/main/java/org/opensearch/discovery/ec2/AwsEc2ServiceImpl.java
@@ -111,7 +111,7 @@ protected Ec2Client buildClient(
     }
 
     protected String getFullEndpoint(String endpoint) {
-        if (endpoint == null) {
+        if (!Strings.hasText(endpoint)) {
             return null;
         }
         if (endpoint.startsWith("http")) {

diff --git a/plugins/discovery-ec2/src/test/java/org/opensearch/discovery/ec2/AwsEc2ServiceImplTests.java b/plugins/discovery-ec2/src/test/java/org/opensearch/discovery/ec2/AwsEc2ServiceImplTests.java
@@ -221,5 +221,7 @@ public void testGetFullEndpointWithoutScheme() {
 
         String endpoint = awsEc2ServiceImpl.getFullEndpoint(clientSettings.endpoint);
         assertEquals("https://ec2.us-west-2.amazonaws.com", endpoint);
+
+        assertNull(awsEc2ServiceImpl.getFullEndpoint(""));
     }
 }