add unit tests

Signed-off-by: Varun Bansal <bansvaru@amazon.com>
opensearch-project · Mar 14, 2024 · 1406e16 · 1406e16
1 parent dde1609
commit 1406e16
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 6 deletions.
diff --git a/server/src/main/java/org/opensearch/index/translog/transfer/FileTransferTracker.java b/server/src/main/java/org/opensearch/index/translog/transfer/FileTransferTracker.java
@@ -76,12 +76,7 @@ public void onSuccess(TransferFileSnapshot fileSnapshot) {
             logger.error("Failure to update translog upload success stats", ex);
         }
 
-        try {
-            // add() gets a dedicated try/catch as its on the critical path
-            add(fileSnapshot.getName(), TransferState.SUCCESS);
-        } catch (IllegalStateException ex) {
-            throw new FileTransferException(fileSnapshot, ex);
-        }
+        add(fileSnapshot.getName(), TransferState.SUCCESS);
     }
 
     void add(String file, boolean success) {

diff --git a/server/src/test/java/org/opensearch/index/translog/transfer/FileTransferTrackerTests.java b/server/src/test/java/org/opensearch/index/translog/transfer/FileTransferTrackerTests.java
@@ -20,6 +20,10 @@
 import java.util.List;
 import java.util.Set;
 
+import static org.mockito.Mockito.anyLong;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.spy;
+
 public class FileTransferTrackerTests extends OpenSearchTestCase {
 
     protected final ShardId shardId = new ShardId("index", "_na_", 1);
@@ -94,6 +98,32 @@ public void testOnFailure() throws IOException {
         }
     }
 
+    public void testOnSuccessStatsFailure() throws IOException {
+        RemoteTranslogTransferTracker localRemoteTranslogTransferTracker = spy(remoteTranslogTransferTracker);
+        doAnswer((count) -> { throw new NullPointerException("Error while updating stats"); }).when(localRemoteTranslogTransferTracker)
+            .addUploadBytesSucceeded(anyLong());
+
+        FileTransferTracker localFileTransferTracker = new FileTransferTracker(shardId, localRemoteTranslogTransferTracker);
+
+        Path testFile = createTempFile();
+        int fileSize = 128;
+        Files.write(testFile, randomByteArrayOfLength(fileSize), StandardOpenOption.APPEND);
+        try (
+            FileSnapshot.TransferFileSnapshot transferFileSnapshot = new FileSnapshot.TransferFileSnapshot(
+                testFile,
+                randomNonNegativeLong(),
+                null
+            );
+        ) {
+            Set<FileSnapshot.TransferFileSnapshot> toUpload = new HashSet<>(2);
+            toUpload.add(transferFileSnapshot);
+            localFileTransferTracker.recordBytesForFiles(toUpload);
+            localRemoteTranslogTransferTracker.addUploadBytesStarted(fileSize);
+            localFileTransferTracker.onSuccess(transferFileSnapshot);
+            assertEquals(localFileTransferTracker.allUploaded().size(), 1);
+        }
+    }
+
     public void testUploaded() throws IOException {
         Path testFile = createTempFile();
         int fileSize = 128;