Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Query editor UI changes #7889

Merged

Conversation

abbyhu2000
Copy link
Member

Description

manual backport of #7866

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.26%. Comparing base (8c779c1) to head (0cb0d4a).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...c/plugins/data/public/ui/search_bar/search_bar.tsx 12.50% 6 Missing and 1 partial ⚠️
...ugins/data/public/ui/filter_bar/filter_options.tsx 0.00% 1 Missing and 2 partials ⚠️
...c/ui/query_editor/editors/default_editor/index.tsx 0.00% 2 Missing ⚠️
.../query_string/language_service/language_service.ts 0.00% 1 Missing ⚠️
.../public/query/query_string/query_string_manager.ts 0.00% 1 Missing ⚠️
...ins/data/public/ui/query_editor/editors/shared.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7889      +/-   ##
==========================================
- Coverage   64.28%   64.26%   -0.03%     
==========================================
  Files        3658     3659       +1     
  Lines       80790    80814      +24     
  Branches    12865    12870       +5     
==========================================
- Hits        51936    51935       -1     
- Misses      25672    25694      +22     
- Partials     3182     3185       +3     
Flag Coverage Δ
Linux_1 30.32% <0.00%> (-0.01%) ⬇️
Linux_2 56.04% <ø> (ø)
Linux_3 40.69% <6.25%> (-0.03%) ⬇️
Linux_4 31.54% <0.00%> (-0.01%) ⬇️
Windows_1 30.34% <0.00%> (-0.01%) ⬇️
Windows_2 55.99% <ø> (ø)
Windows_3 40.70% <6.25%> (-0.02%) ⬇️
Windows_4 31.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Aug 28, 2024
docs/_sidebar.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@ashwin-pc ashwin-pc merged commit abed5ba into opensearch-project:2.x Aug 28, 2024
64 of 65 checks passed
@ashwin-pc ashwin-pc added discover for discover reinvent v2.17.0 labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants