Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] search use case overview page #7877

Merged
merged 14 commits into from
Sep 3, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Aug 28, 2024

Description

Add search use case overview page

breadcrumbs will handled by other PR

Issues Resolved

#7807

Screenshot

image

Testing the changes

Changelog

  • feat: [Workspace] Add search use case overview page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 22 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (976c567) to head (5183791).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/home/public/plugin.ts 11.11% 7 Missing and 1 partial ⚠️
src/plugins/workspace/public/utils.ts 41.66% 6 Missing and 1 partial ⚠️
...rc/plugins/home/public/application/application.tsx 25.00% 3 Missing ⚠️
...ponents/usecase_overview/search_use_case_setup.tsx 87.50% 2 Missing ⚠️
...ent/public/components/card_container/card_list.tsx 66.66% 0 Missing and 1 partial ⚠️
...omponents/usecase_overview/search_use_case_app.tsx 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7877   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3685     3687    +2     
  Lines       87143    87191   +48     
  Branches    13405    13411    +6     
=======================================
+ Hits        53169    53200   +31     
- Misses      30755    30770   +15     
- Partials     3219     3221    +2     
Flag Coverage Δ
Linux_1 29.35% <15.90%> (-0.02%) ⬇️
Linux_2 56.22% <ø> (ø)
Linux_3 37.81% <12.50%> (?)
Linux_4 29.61% <63.04%> (+0.02%) ⬆️
Windows_1 29.37% <15.90%> (-0.02%) ⬇️
Windows_2 56.17% <ø> (ø)
Windows_3 37.81% <12.50%> (-0.01%) ⬇️
Windows_4 29.61% <63.04%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am changed the title Search use case [Workspace] search use case overview page Aug 28, 2024
Hailong-am and others added 5 commits August 28, 2024 17:49
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am and others added 5 commits August 30, 2024 23:44
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@@ -168,6 +174,36 @@ export class HomePublicPlugin
workspaceAvailability: WorkspaceAvailability.outsideWorkspace,
});

if (core.chrome.navGroup.getNavGroupEnabled()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not sure if it is suitable to register the page inside home plugin.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, It's a little wired we put into home plugin, we might need to have a new plugin to store use case overview pages.

@ruanyl ruanyl merged commit 9697f33 into opensearch-project:main Sep 3, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7877-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9697f33da4bfab7e0dc1f10b308c152739a982ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7877-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7877-to-2.x.

@Hailong-am
Copy link
Collaborator Author

Hailong-am commented Sep 3, 2024

backport depends on #7937 to merged first

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
* search overview

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* add unit test for search use case overview page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7877 created/updated

* fix merge issue

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate breadcrumbs for workspace overview page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix failed ut

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix merge issue

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix ut

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9697f33)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 4, 2024
* search overview



* add unit test for search use case overview page



* Changeset file for PR #7877 created/updated

* fix merge issue



* udpate breadcrumbs for workspace overview page



* fix failed ut



* fix merge issue



* fix ut



---------




(cherry picked from commit 9697f33)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-7877-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9697f33da4bfab7e0dc1f10b308c152739a982ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7877-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-7877-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
* search overview

* add unit test for search use case overview page

* Changeset file for PR #7877 created/updated

* fix merge issue

* udpate breadcrumbs for workspace overview page

* fix failed ut

* fix merge issue

* fix ut

---------

(cherry picked from commit 9697f33)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 3d7b9ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
* search overview

* add unit test for search use case overview page

* Changeset file for PR #7877 created/updated

* fix merge issue

* udpate breadcrumbs for workspace overview page

* fix failed ut

* fix merge issue

* fix ut

---------

(cherry picked from commit 9697f33)






(cherry picked from commit 3d7b9ed)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants