Add flush to TopNavControlLinkData
#7801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
sejli
approved these changes
Aug 22, 2024
| @@ -60,6 +60,7 @@ export function TopNavControlItem(props: TopNavControlData) { | |||
| {props.description} | |||
| {links?.map((linkProps) => ( | |||
| <> | |||
| {' '} | |||
There was a problem hiding this comment.
Thanks for the attention to detail. Yes. When multiple links are added, this ensures that some collapsable space exists between them. It also adds space before the first one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7801 +/- ##
=======================================
Coverage 63.80% 63.80%
=======================================
Files 3656 3656
Lines 81210 81210
Branches 12950 12950
=======================================
Hits 51812 51812
Misses 26217 26217
Partials 3181 3181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
approved these changes
Aug 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add `flush` to `TopNavControlLinkData` Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7801 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit a5882ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add `flush` to `TopNavControlLinkData` * Changeset file for PR #7801 created/updated --------- (cherry picked from commit a5882ee) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
flushtoTopNavControlLinkDataChangelog
flushtoTopNavControlLinkDataCheck List
yarn test:jestyarn test:jest_integration