Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Refactor: Workspace list card #7748

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Aug 19, 2024

Description

  1. click workspace name will navigates to workspace use case overview page
  2. new empty state for workspace list card
  3. create workspace button with new style

Issues Resolved

#7747

Screenshot

image

image

image

Testing the changes

Changelog

  • feat: [Workspace]Fix click on workspace name not navigates to use case overview page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (b4ae264) to head (b8a3b1a).
Report is 175 commits behind head on main.

Files with missing lines Patch % Lines
...ic/components/service_card/workspace_list_card.tsx 84.21% 1 Missing and 2 partials ⚠️
...onents/workspace_detail/workspace_detail_panel.tsx 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7748   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files        3656     3656           
  Lines       81190    81207   +17     
  Branches    12945    12951    +6     
=======================================
+ Hits        51794    51808   +14     
+ Misses      26217    26216    -1     
- Partials     3179     3183    +4     
Flag Coverage Δ
Linux_1 30.07% <77.77%> (+0.01%) ⬆️
Linux_2 55.87% <ø> (ø)
Linux_3 40.42% <ø> (-0.01%) ⬇️
Linux_4 31.28% <ø> (ø)
Windows_1 30.09% <77.77%> (+0.01%) ⬆️
Windows_2 55.82% <ø> (ø)
Windows_3 40.42% <ø> (ø)
Windows_4 31.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am changed the title Workspace list card 217 [Workspace] Refactor: Workspace list card Aug 19, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>

click on workspace name navigates to use case overview page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Changeset file for PR opensearch-project#7748 created/updated

support customized width

Signed-off-by: Hailong Cui <ihailong@amazon.com>

style adjustment

Signed-off-by: Hailong Cui <ihailong@amazon.com>

update test snapshot

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@ruanyl ruanyl merged commit a550601 into opensearch-project:main Aug 23, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
click on workspace name navigates to use case overview page

Changeset file for PR #7748 created/updated

support customized width

style adjustment

update test snapshot

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit a550601)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 23, 2024
click on workspace name navigates to use case overview page

Changeset file for PR #7748 created/updated

support customized width

style adjustment

update test snapshot



(cherry picked from commit a550601)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants