Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation]feat: replace analytics nav group with essentials #7618

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[navigation]feat: replace analytics nav group with essentials #7618

merged 9 commits into from
Aug 8, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 5, 2024 •
edited
Loading

Description

For 2.17, we are using

  • essentials to replace analytics.
  • Analytics (All) to replace all.

Issues Resolved

Screenshot

image

Before the change

image

After the change

image

Testing the changes

Changelog

  • feat: use essentials as the nav group name

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe changed the title [navigation]feat: use essentials as the nav group name [navigation]feat: replace analytics nav group with essentials Aug 5, 2024
opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 5, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7618 created/updated
cd46867
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.67%. Comparing base (ca89488) to head (3e5b1d5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7618   +/-   ##
=======================================
  Coverage   63.67%   63.67%           
=======================================
  Files        3633     3633           
  Lines       80105    80105           
  Branches    12693    12693           
=======================================
  Hits        51009    51009           
  Misses      25987    25987           
  Partials     3109     3109
Flag Coverage Δ
Linux_1 30.59% <0.00%> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.55% <60.00%> (-0.01%) ⬇️
Linux_4 31.30% <50.00%> (ø)
Windows_1 30.61% <0.00%> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.56% <60.00%> (ø)
Windows_4 31.30% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe and others added 7 commits August 7, 2024 16:33
@SuZhou-Joe
feat: use essentials
f31239e 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: fix home
73e61bd 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@opensearch-changeset-bot @SuZhou-Joe
Changeset file for PR opensearch-project#7618 created/updated
5b2f417
@SuZhou-Joe
feat: change all use case name
88c7cc4 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: use uppercase
afe92a7 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: fix unit test error
f79b1fd 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
fix: unit test
49e7d6b 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: reserve analytics id
5da3475 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update title
3e5b1d5 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@opensearch-project opensearch-project deleted a comment from github-actions bot Aug 7, 2024
wanglam
wanglam reviewed Aug 8, 2024
View reviewed changes
src/core/utils/default_nav_groups.ts
@@ -64,16 +64,16 @@ const defaultNavGroups = {
}),
order: 5000,
},
analytics: {
essentials: {
id: 'analytics',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Shall we add some comments here to show why we still using analytics instead of essentials?

@ananzh ananzh merged commit 7bcb949 into opensearch-project:main Aug 8, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2024
@github-actions @opensearch-changeset-bot
[navigation]feat: replace analytics nav group with essentials (#7618)
2d4bdad 
* feat: use essentials
* feat: fix home
* feat: change all use case name
* feat: use uppercase
* feat: reserve analytics id
* feat: update title

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7bcb949)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 9, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Aug 12, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[navigation]feat: replace analytics nav group with essentials (#7618) (…
7d01267 
…#7668)

* feat: use essentials
* feat: fix home
* feat: change all use case name
* feat: use uppercase
* feat: reserve analytics id
* feat: update title

---------



(cherry picked from commit 7bcb949)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@wanglam wanglam wanglam approved these changes

@ananzh ananzh ananzh approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x navigation v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuZhou-Joe @ruanyl @wanglam @ananzh