fix: update icon of recent items from OUI library to enable dark mode #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
SuZhou-Joe
approved these changes
Jul 26, 2024
ruanyl
approved these changes
Jul 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7508 +/- ##
==========================================
- Coverage 64.13% 64.11% -0.02%
==========================================
Files 3616 3615 -1
Lines 78759 78757 -2
Branches 12453 12453
==========================================
- Hits 50511 50496 -15
- Misses 25194 25206 +12
- Partials 3054 3055 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…#7508) * fix: use icon from library to enable dark mode Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #7508 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit fc1adfa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…#7508) * fix: use icon from library to enable dark mode Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #7508 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit fc1adfa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 26, 2024
…#7508) (#7513) * fix: use icon from library to enable dark mode * Changeset file for PR #7508 created/updated --------- (cherry picked from commit fc1adfa) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 26, 2024
…#7508) (#7514) * fix: use icon from library to enable dark mode * Changeset file for PR #7508 created/updated --------- (cherry picked from commit fc1adfa) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
paulstn
pushed a commit
to paulstn/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
…opensearch-project#7508) * fix: use icon from library to enable dark mode Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#7508 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
…opensearch-project#7508) * fix: use icon from library to enable dark mode Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#7508 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update icon of recent items from OUI library to enable dark mode.
Before we use svg code directly to render icon, however this icon would not be updated with dark mode. We will use a icon of OUI for now, and once replace in #7354
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration