Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Workspace] Navigate to detail page when clicking all use case workspace #7405

Merged
merged 2 commits into from
Jul 24, 2024
Merged

[Bug][Workspace] Navigate to detail page when clicking all use case workspace #7405

merged 2 commits into from
Jul 24, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Clicking workspace with all use case in the picker should navigate to workspace detail page

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: [Bug][Workspace] Navigate to detail page when clicking all use case workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
[Bug] Clicking workspace with all use case in the picker should navig…
a17f68b 
…ate to workspace details page

Signed-off-by: yubonluo <yubonluo@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.02%. Comparing base (5ee9b69) to head (a21b5d2).
Report is 5 commits behind head on main.

Files Patch % Lines
...ublic/components/workspace_menu/workspace_menu.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7405      +/-   ##
==========================================
+ Coverage   63.98%   64.02%   +0.04%     
==========================================
  Files        3598     3603       +5     
  Lines       78322    78478     +156     
  Branches    12352    12382      +30     
==========================================
+ Hits        50111    50247     +136     
- Misses      25189    25206      +17     
- Partials     3022     3025       +3
Flag Coverage Δ
Linux_1 30.68% <66.66%> (-0.40%) ⬇️
Linux_2 55.58% <ø> (ø)
Linux_3 40.64% <ø> (-0.65%) ⬇️
Linux_4 31.69% <ø> (+0.17%) ⬆️
Windows_1 30.70% <66.66%> (-0.40%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 40.65% <ø> (-0.65%) ⬇️
Windows_4 31.69% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the quick fix!

@SuZhou-Joe SuZhou-Joe merged commit 67670fd into opensearch-project:main Jul 24, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@github-actions @opensearch-changeset-bot
[Bug][Workspace] Navigate to detail page when clicking all use case w…
cffa4c7 
…orkspace (#7405)

* [Bug] Clicking workspace with all use case in the picker should navigate to workspace details page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7405 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 67670fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@github-actions @opensearch-changeset-bot
[Bug][Workspace] Navigate to detail page when clicking all use case w…
b787152 
…orkspace (#7405)

* [Bug] Clicking workspace with all use case in the picker should navigate to workspace details page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7405 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 67670fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Bug][Workspace] Navigate to detail page when clicking all use case w…
587b319 
…orkspace (#7405) (#7431)

* [Bug] Clicking workspace with all use case in the picker should navigate to workspace details page



* Changeset file for PR #7405 created/updated

---------



(cherry picked from commit 67670fd)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Bug][Workspace] Navigate to detail page when clicking all use case w…
a7d8733 
…orkspace (#7405) (#7430)

* [Bug] Clicking workspace with all use case in the picker should navigate to workspace details page



* Changeset file for PR #7405 created/updated

---------



(cherry picked from commit 67670fd)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 seasoned-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yubonluo @ruanyl @SuZhou-Joe