[1.x][Test] Wrap FunComponent in unit test with IntlProvider #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the FunctionComponent unit tests, we see many console errors: `Could not find required intl object. <IntlProvider> needs to exist in the component ancestry. ` This is because for some unit tests, we mount the FunctionComponent (with Enzyme's mount()) , which access to the react-intl context by FormattedMessage without their <IntlProvider /> parent wrapper. This PR solves 7 out of 8 unit tests with this issue by wrapping the <IntlProvider /> either through original enzyme_helper functions or a simple wrapper wrapWithIntl. Partically Resolved: opensearch-project#593 Backport PR: opensearch-project#654 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
|
✅ DCO Check Passed 5857a22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the FunctionComponent unit tests, we see many console errors:
Could not find required intl object. <IntlProvider> needs to exist in the component ancestry.This is because for some unit tests, we mount the FunctionComponent
(with Enzyme's mount()) , which access to the react-intl context by
FormattedMessage without their parent wrapper.
This PR solves 7 out of 8 unit tests with this issue by wrapping the
either through original enzyme_helper functions or
a simple wrapper wrapWithIntl.
Partically Resolved:
#593
Backport PR:
#654
Signed-off-by: Anan Zhuang ananzh@amazon.com
Check List