Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Add error state to all data source menu components to show error component and consolidate all fetch errors #6440

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Apr 13, 2024

Description

This change adds error state to all data source menu components to show error component and consolidate all fetch errors

Issues Resolved

Closes #6439

Screenshot

Testing the changes

UI test to show toast with same error message and error component for different data source components:

  1. data source selectable
    Screenshot from 2024-04-12 23-41-51

  2. data source multi select
    Screenshot from 2024-04-12 23-40-16

  3. data source aggregated
    Screenshot from 2024-04-12 23-40-50

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 45.11%. Comparing base (e785fd3) to head (8f756a4).
Report is 8 commits behind head on main.

❗ Current head 8f756a4 differs from pull request most recent head 8e88fae. Consider uploading reports for the commit 8e88fae to get more accurate results

Files Patch % Lines
...ce_aggregated_view/data_source_aggregated_view.tsx 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6440      +/-   ##
==========================================
- Coverage   49.55%   45.11%   -4.45%     
==========================================
  Files        2670     1652    -1018     
  Lines       54290    33522   -20768     
  Branches     8878     6372    -2506     
==========================================
- Hits        26906    15124   -11782     
+ Misses      25720    17232    -8488     
+ Partials     1664     1166     -498     
Flag Coverage Δ
Linux_3 45.11% <83.33%> (?)
Windows_1 ?
Windows_3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seraphjiang seraphjiang added the multiple datasource multiple datasource project label Apr 13, 2024
@yujin-emma
Copy link
Contributor

LGTM

zhongnansu
zhongnansu previously approved these changes Apr 16, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
ZilongX
ZilongX previously approved these changes Apr 16, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
@zhongnansu zhongnansu merged commit b9c703b into opensearch-project:main Apr 16, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6440-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9c703bc39c915cb5c240f0930acd9d1a43f4e68
# Push it to GitHub
git push --set-upstream origin backport/backport-6440-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6440-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 17, 2024
…nts to show error component and consolidate all fetch errors (#6440)

* add error state to all components

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

* resolve conflict and fix tests

Signed-off-by: Lu Yu <nluyu@amazon.com>

* move import up

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit b9c703b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
BionIT pushed a commit that referenced this pull request Apr 17, 2024
…nts to show error component and consolidate all fetch errors (#6440) (#6516)

* add error state to all components

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

* resolve conflict and fix tests

Signed-off-by: Lu Yu <nluyu@amazon.com>

* move import up

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit b9c703b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants