[Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6129

BionIT · 2024-03-13T04:28:06Z

Description

This change is based on requirement to show readonly view for all compatible connected data sources in the navigation bar, and also is capable of showing only the data sources passed by the plugins

Issues Resolved

Screenshot

readonlyaggregatedview.mp4

Testing the changes

The following were performed in the recording above:

enable data source plugin
change prop to not display all compatible data sources and pass in active data source ids should show the info icon and clicking on it, will show drop down with title called SELECTED DATA SOURCES, the button should show the number of active/used data sources
change prop to display all compatible data sources and remove active data source ids should show the info icon and clicking on it, will show drop down with title called DATA SOURCES followed by number of compatible data sources and display them.

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…r only used data sources Signed-off-by: Lu Yu <nluyu@amazon.com>

Signed-off-by: Lu Yu <nluyu@amazon.com>

codecov · 2024-03-13T04:41:47Z

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 67.22%. Comparing base (8c4f49a) to head (8f555f2).

Files	Patch %	Lines
...ce_aggregated_view/data_source_aggregated_view.tsx	84.37%	2 Missing and 3 partials ⚠️
...c/components/data_source_menu/data_source_menu.tsx	0.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6129      +/-   ##
==========================================
+ Coverage   67.20%   67.22%   +0.01%     
==========================================
  Files        3333     3334       +1     
  Lines       64565    64602      +37     
  Branches    10391    10402      +11     
==========================================
+ Hits        43394    43430      +36     
+ Misses      18638    18635       -3     
- Partials     2533     2537       +4

Flag	Coverage Δ
Linux_1	`31.69% <ø> (ø)`
Linux_2	`55.45% <ø> (ø)`
Linux_3	`?`
Linux_4	`34.95% <0.00%> (-0.04%)`	⬇️
Windows_1	`31.72% <ø> (?)`
Windows_2	`55.41% <ø> (ø)`
Windows_3	`44.71% <75.00%> (+0.03%)`	⬆️
Windows_4	`34.95% <0.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...rce_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx

Signed-off-by: Lu Yu <nluyu@amazon.com>

Flyingliuhub · 2024-03-15T23:41:33Z

...rce_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx

+        }
+      })
+      .catch(() => {
+        this.props.notifications.addWarning(


We catch warning notifications here, but we didn't change the component state, do we need to set state to reflect the error condition?

If there is error, this will show a toast about the error

AMoo-Miki · 2024-03-21T17:51:22Z

src/plugins/data_source_management/public/components/data_source_menu/data_source_menu.tsx

+  if (!showDataSourceSelectable && !showDataSourceView && !showDataSourceAggregatedView) {
    return null;
  }


These 3 boolean values are used to control the appearance of this component. If it was just one variable, it would have been acceptable but anything more than one variable controlling how exclusively something is rendered is wrong. This has to be changed to a single ENUM variable.

PS: this piece of code cannot remain in the repo as is.

Thanks for the comment! Will address this in #6239 if the proposed change looks good @AMoo-Miki

…patible data sources or only show used data sources (#6129) * add data source aggregated view to show all compatible data sources or only used data sources Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * address comments and add more tests Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 05abf5e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

…patible data sources or only show used data sources (#6129) (#6264) * add data source aggregated view to show all compatible data sources or only used data sources Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * address comments and add more tests Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 05abf5e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

add data source aggregated view to show all compatible data sources o…

9b55d55

…r only used data sources Signed-off-by: Lu Yu <nluyu@amazon.com>

BionIT requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn, SuZhou-Joe and ruanyl as code owners March 13, 2024 04:28

github-actions bot added the seasoned-contributor label Mar 13, 2024

add change log

c7f2ec2

Signed-off-by: Lu Yu <nluyu@amazon.com>

xinruiba reviewed Mar 13, 2024

View reviewed changes

...rce_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Outdated Show resolved Hide resolved

xinruiba reviewed Mar 13, 2024

View reviewed changes

...rce_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Outdated Show resolved Hide resolved

yujin-emma approved these changes Mar 13, 2024

View reviewed changes

ruanyl reviewed Mar 13, 2024

View reviewed changes

ruanyl added the multiple datasource multiple datasource project label Mar 13, 2024

BionIT added 2 commits March 14, 2024 19:49

address comments and add more tests

f55f084

Signed-off-by: Lu Yu <nluyu@amazon.com>

Merge branch 'main' into aaggregateddatasourceview

633b2ed

Signed-off-by: Lu Yu <nluyu@amazon.com>

BionIT added the v2.14.0 label Mar 15, 2024

Merge branch 'main' into aaggregateddatasourceview

f6dbf31

Signed-off-by: Lu Yu <nluyu@amazon.com>

ZilongX approved these changes Mar 15, 2024

View reviewed changes

Merge branch 'main' into aaggregateddatasourceview

8f555f2

Flyingliuhub reviewed Mar 15, 2024

View reviewed changes

Flyingliuhub approved these changes Mar 15, 2024

View reviewed changes

Merge branch 'main' into aaggregateddatasourceview

ffd2f6f

BionIT merged commit 05abf5e into opensearch-project:main Mar 16, 2024
7 checks passed

This was referenced Mar 19, 2024

[Meta] [2.14] Security, bug fix and enhancemanet for dashboards anywhere #5872

Closed

[Meta][UX][Multiple Datasource] Improvement to data source components in the navigation bar #6216

Closed

AMoo-Miki reviewed Mar 21, 2024

View reviewed changes

BionIT added the backport 2.x label Mar 25, 2024

opensearch-trigger-bot bot mentioned this pull request Mar 25, 2024

[Backport 2.x] [Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6264

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6129

[Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6129

BionIT commented Mar 13, 2024

codecov bot commented Mar 13, 2024 •

edited

Loading

Flyingliuhub Mar 15, 2024

BionIT Mar 16, 2024

AMoo-Miki Mar 21, 2024 •

edited

Loading

BionIT Mar 21, 2024

[Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6129

[Multiple Datasource] Add data source aggregated view to show all compatible data sources or only show used data sources #6129

Conversation

BionIT commented Mar 13, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Mar 13, 2024 • edited Loading

Codecov Report

Flyingliuhub Mar 15, 2024

Choose a reason for hiding this comment

BionIT Mar 16, 2024

Choose a reason for hiding this comment

AMoo-Miki Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

BionIT Mar 21, 2024

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2024 •

edited

Loading

AMoo-Miki Mar 21, 2024 •

edited

Loading