[BUG] Allow clicking back to top in Discover #6007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
…g to top The original window.scrollTo(0, 0) will reset the window back but not table. In this PR, we add a table wrapper to allow scroll back on table. Issue Resolve: opensearch-project#6006 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
|
Add |
Flyingliuhub
approved these changes
Mar 3, 2024
|
Found a more standard solution using EuiPanel panelRef, raising a new one #6008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original window.scrollTo(0, 0) will reset the window back but not table. In this PR, we add a table wrapper to allow scroll back on table.
Issues Resolved
#6006
Check List
yarn test:jestyarn test:jest_integration