Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEVELOPER_GUIDE.md #3764

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

Nicksqain
Copy link
Contributor

@Nicksqain Nicksqain commented Apr 1, 2023

Description

Added micro changes for DEVELOPER_GUIDE.md.

  • Expanded bootstrap timeout error context.
  • Added solution to problem with insufficient allocated memory.

Issues Resolved

#3759 (Just a reference)

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
@Nicksqain Nicksqain requested a review from a team as a code owner April 1, 2023 19:37
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions to the dev guide, thanks!

@ashwin-pc ashwin-pc added the OSCI Open Source Contributor Initiative label Apr 3, 2023
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you~~

@ananzh ananzh merged commit 174756f into opensearch-project:main Apr 7, 2023
@ananzh ananzh added the v2.7.0 label Apr 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 7, 2023
* Update for devguide.md
* Add changelog entry

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
(cherry picked from commit 174756f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ashwin-pc pushed a commit that referenced this pull request Apr 11, 2023
* Update DEVELOPER_GUIDE.md (#3764)

* Update for devguide.md
* Add changelog entry

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
(cherry picked from commit 174756f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

* add changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
* Update for devguide.md
* Add changelog entry

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x OSCI Open Source Contributor Initiative v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants