Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom tooltips and clicking functionality to vega charts #3369

Closed
wants to merge 1 commit into from
Closed

Add custom tooltips and clicking functionality to vega charts #3369

wants to merge 1 commit into from

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Feb 1, 2023

Signed-off-by: Tyler Ohlsen ohltyler@amazon.com

Description

This is a draft PR highlighting the entry points for injecting custom tooltips and custom clicking functionality in the vega charts.

These may be moved depending on where they will live, potentially in a new Vega View. Details in the related issue #3317

@ohltyler
Add entrypoints for custom tooltips & clicking
c0ec0aa 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler requested a review from a team as a code owner February 1, 2023 23:22
@ohltyler ohltyler marked this pull request as draft February 1, 2023 23:22
@ohltyler ohltyler mentioned this pull request Feb 6, 2023
Closed
@joshuarrrr joshuarrrr self-assigned this Mar 10, 2023
@joshuarrrr
Copy link
Member

@ohltyler Is this draft still needed, or is it superseded by #3777?

@ohltyler ohltyler closed this Apr 26, 2023
@ohltyler
Copy link
Member Author

The latter. Closing this one.

@kavilla kavilla added v2.9.0 and removed v2.8.0 labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

Assignees

@joshuarrrr joshuarrrr

Labels
feature-anywhere v2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohltyler @joshuarrrr @kavilla