[Backport 2.x] [Viz Builder] State validation before dispatching and loading #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## 2.x #2449 +/- ##
======================================
Coverage ? 66.74%
======================================
Files ? 3197
Lines ? 60828
Branches ? 9243
======================================
Hits ? 40601
Misses ? 18019
Partials ? 2208 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ashwin-pc
approved these changes
Sep 29, 2022
* State validation before dispatching Validate style and visualization state schema before dispatching state updates when loading wizard. Show error via toast. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fixes and add unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add PR to changelog.md Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 0279588)
ashwin-pc
force-pushed
the
backport/backport-2351-to-2.x
branch
from
c2e420d
to
b031f81
Compare
kavilla
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0279588 from #2351