Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Viz Builder] State validation before dispatching and loading #2351

Merged
merged 3 commits into from
Sep 29, 2022
Merged

[Viz Builder] State validation before dispatching and loading #2351

merged 3 commits into from
Sep 29, 2022

Commits on Sep 28, 2022

  1. State validation before dispatching 

    Validate style and visualization state schema before dispatching state updates
when loading wizard. Show error via toast.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    @abbyhu2000
    abbyhu2000 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    a60c2da View commit details
    Browse the repository at this point in the history

  2. Fixes and add unit tests 

    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    @abbyhu2000
    abbyhu2000 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2d99206 View commit details
    Browse the repository at this point in the history

  3. Add PR to changelog.md 

    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    @abbyhu2000
    abbyhu2000 committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5668bad View commit details
    Browse the repository at this point in the history