Update unit tests #233

kavilla · 2021-03-24T01:28:40Z

Description

Update unit tests to succeed. Updating the tests where it needs to be in expectations, or potentially some missed updates, or even ignoring some directories because they are no longer relevant. Also, included updating the compressed files that get uncompressed during test run and verified.

Some snapshots had to be updated again as well.

Issues Resolved

#207

Check List

New functionality includes testing.
- All tests pass (unit tests at least)
~~New functionality has been documented.~~
- ~~New functionality has javadoc added~~
Commits are signed per the DCO using --signoff

odfe-release-bot · 2021-03-24T01:32:35Z

✅ DCO Check Passed 2a5aebe

..._pattern_wizard/components/step_index_pattern/__snapshots__/step_index_pattern.test.tsx.snap

...ensearch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap

src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx

ananzh

looks good. only a few check.

~25 failures still. I need to update the project to just ignore the maps directory completely for tests instead of just ignoring one test. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

8 failures still. Committing here because the remaining but require an agreement of next steps. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-24T21:46:28Z

✅ DCO Check Passed 7d42286

odfe-release-bot · 2021-03-24T22:00:55Z

✅ DCO Check Passed 499711f

odfe-release-bot · 2021-03-24T22:35:02Z

✅ DCO Check Passed 20d3952

Files were uncompressed, renamed, and then compressed again for unit tests. Signed-off-by: Kawika Avilla <avillk@amazon.com>

odfe-release-bot · 2021-03-24T22:40:59Z

✅ DCO Check Passed 4f390a6

…t.js Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-25T17:36:30Z

✅ DCO Check Passed c314dbd

Updated references to OpenSearch and OpenSearch Dashboards for the zipped files with the cli_plugin for the tests to pass. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-25T18:36:52Z

✅ DCO Check Passed 8c44e54

This test checks if image exists but this image was removed in the renaming process at this commit: 3ecadd0. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-25T19:58:30Z

✅ DCO Check Passed e3a9612

Updating a test that discovers plugins to have the correct amount. The original tests removed the creation of the mock related to x-pack. Update the test to get the correct values while running tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-25T20:15:04Z

✅ DCO Check Passed b93ef34

kavilla · 2021-03-25T21:00:32Z

Results:

Test Suites: 24 skipped, 1415 passed, 1415 of 1439 total
Tests:       257 skipped, 9 todo, 10359 passed, 10625 total
Snapshots:   2369 passed, 2369 total
Time:        187.572 s
Ran all test suites.
Done in 190.65s.

boktorbb

Looks good. Just one question

src/core/public/doc_links/doc_links_service.test.ts

src/cli_plugin/install/pack.test.js

src/cli_plugin/install/zip.test.js

src/core/server/plugins/discovery/plugins_discovery.test.ts

src/dev/jest/config.js

src/plugins/advanced_settings/public/management_app/lib/get_category_name.test.ts

src/plugins/opensearch_dashboards_react/public/markdown/markdown.test.tsx

src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx

PR comment to include RENAMEME for easy grepping and update a ref to opensearch.com to opensearch.co so that it is easier to grep while renaming. Then had to regenerate the snapshots. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

odfe-release-bot · 2021-03-26T19:10:37Z

✅ DCO Check Passed 4fcc7bb

boktorbb

looks good

mihirsoni

LGTM !!

* [Tests] A few easy fixes for unit tests ~25 failures still. I need to update the project to just ignore the maps directory completely for tests instead of just ignoring one test. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] exclude maps from jest Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] More easy fixes for unit tests 8 failures still. Committing here because the remaining but require an agreement of next steps. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] Update compressed files for unit tests Files were uncompressed, renamed, and then compressed again for unit tests. Signed-off-by: Kawika Avilla <avillk@amazon.com> * [Tests] Rename cli_plugin/kibana.test.js to opensearch_dashboards.test.js Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] update zip files in cli_plugin Updated references to OpenSearch and OpenSearch Dashboards for the zipped files with the cli_plugin for the tests to pass. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] remove optimize/image tests This test checks if image exists but this image was removed in the renaming process at this commit: 3ecadd0. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] update plugins_discovery test Updating a test that discovers plugins to have the correct amount. The original tests removed the creation of the mock related to x-pack. Update the test to get the correct values while running tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] update TODOs with [RENAMEME] and ref to .com PR comment to include RENAMEME for easy grepping and update a ref to opensearch.com to opensearch.co so that it is easier to grep while renaming. Then had to regenerate the snapshots. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

…ect#192) (opensearch-project#233) * [Workspace][Feature] Left navigation menu adjustment (opensearch-project#192) * add util function to filter workspace feature by wildcard Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update tests and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * small adjustment to left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve git conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename nav link service function Signed-off-by: yuye-aws <yuyezhu@amazon.com> * unit test for workspace plugin.ts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflicts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * restore snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update tests Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>

ananzh reviewed Mar 24, 2021

View reviewed changes

..._pattern_wizard/components/step_index_pattern/__snapshots__/step_index_pattern.test.tsx.snap Outdated Show resolved Hide resolved

ananzh reviewed Mar 24, 2021

View reviewed changes

..._pattern_wizard/components/step_index_pattern/__snapshots__/step_index_pattern.test.tsx.snap Outdated Show resolved Hide resolved

ananzh reviewed Mar 24, 2021

View reviewed changes

...ensearch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap Outdated Show resolved Hide resolved

ananzh reviewed Mar 24, 2021

View reviewed changes

src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx Show resolved Hide resolved

ananzh requested changes Mar 24, 2021

View reviewed changes

kavilla added 3 commits March 24, 2021 18:50

[Tests] A few easy fixes for unit tests

ed6fc66

~25 failures still. I need to update the project to just ignore the maps directory completely for tests instead of just ignoring one test. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

[Tests] exclude maps from jest

79c20a8

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

[Tests] More easy fixes for unit tests

7d42286

8 failures still. Committing here because the remaining but require an agreement of next steps. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla force-pushed the update-unit-tests branch from 2a5aebe to 7d42286 Compare March 24, 2021 21:43

[Tests] Update compressed files for unit tests

4f390a6

Files were uncompressed, renamed, and then compressed again for unit tests. Signed-off-by: Kawika Avilla <avillk@amazon.com>

kavilla force-pushed the update-unit-tests branch from 20d3952 to 4f390a6 Compare March 24, 2021 22:38

ananzh previously approved these changes Mar 25, 2021

View reviewed changes

[Tests] Rename cli_plugin/kibana.test.js to opensearch_dashboards.tes…

c314dbd

…t.js Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla dismissed ananzh’s stale review via c314dbd March 25, 2021 17:33

[Tests] update zip files in cli_plugin

8c44e54

Updated references to OpenSearch and OpenSearch Dashboards for the zipped files with the cli_plugin for the tests to pass. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

[Tests] remove optimize/image tests

e3a9612

This test checks if image exists but this image was removed in the renaming process at this commit: 3ecadd0. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla requested review from mihirsoni, boktorbb and ananzh March 25, 2021 20:51

kavilla added the >Fork label Mar 25, 2021

kavilla added the test:unit label Mar 25, 2021

kavilla added this to the Beta release milestone Mar 25, 2021

kavilla marked this pull request as ready for review March 25, 2021 20:54

kavilla linked an issue Mar 25, 2021 that may be closed by this pull request

[Tests] Ensure Unit test cases pass #207

Closed

3 tasks

boktorbb previously approved these changes Mar 25, 2021

View reviewed changes

src/core/public/doc_links/doc_links_service.test.ts Outdated Show resolved Hide resolved