Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] fixed folder to snake case #220

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 23, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

@kavilla
Copy link
Member Author

kavilla commented Mar 23, 2021

Precommit checks the files that are changed within the commit. When running the snapshot update files these files got touched and checked by the pre-commit linter caught that these specific folders need to be snake_case. After changing opensearch-dashboards to opensearch_dashboards the pre-commit check succeeded.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kavilla kavilla merged commit ca825b4 into opensearch-project:main Mar 23, 2021
kavilla added a commit that referenced this pull request Mar 23, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla deleted the update-casing-saved-objects-folder branch March 24, 2021 18:31
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants