Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Backport PR for build, maps, branding logging #1119

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jan 10, 2022

Backport PR for:

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

kavilla and others added 5 commits January 10, 2022 17:43
Out of the box, the rendering service will check the config
and see the default value and log an info message saying that
the branding config is invalid or not set. Everytime
you refresh the browser you will get those log messages.

This sets it to only log error messages if the user sets
the branding config and it is invalid.

Include using default messages.

Backport PR:
opensearch-project#941

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Clean up temp aws paths in code base.
Add a configurable flag `showRegionBlockedWarning` into map plugin level config file.

Backport PR:
opensearch-project#1015

Signed-off-by: Zuocheng Ding <zding817@gmail.com>
Forwarding legacy app to the current format of the application.
This enables the usage of stored URLs and other links that referenced
the format of the application URL that mentioned the application name.

Since we changed the URL forwarding we changed this value and released.
So incase forks were made and depended on this legacy formatted reference
of the application. It will still work. There are also references of the
application.

Issue resolved:
opensearch-project#1013

Backport PR:
opensearch-project#1021

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Removed missed reference in CONVENTIONS.md.

Issue related:
opensearch-project#1109

Backport PR:
opensearch-project#1110

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Removes the SEMVAR check for external plugins. 7.9 is not relevant
to the application.

The semvar library was also preventing major.minor.patch.x which is the
format from OpenSearch plugins.

Related issue:
opensearch-project#992

Backport PR:
opensearch-project#1029

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Copy link
Member Author

kavilla commented Jan 11, 2022

Screen Shot 2022-01-10 at 5 12 50 PM

@tmarkley tmarkley requested a review from a team January 11, 2022 17:48
@kavilla kavilla merged commit f21558c into opensearch-project:1.x Jan 13, 2022
@kavilla kavilla deleted the avillk/20220110_backport_br branch January 13, 2022 10:32
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
…-project#1119)

The opensearch-project#1087 PR introduced a regression where the useDefaultGroupDomain was not considered when
computing the scale configs.
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [28.2.0](elastic/elastic-charts@v28.1.0...v28.2.0) (2021-04-15)

### Bug Fixes

* **xy:** consider `useDefaultGroupDomain` on scale config ([opensearch-project#1119](elastic/elastic-charts#1119)) ([269ff1a](elastic/elastic-charts@269ff1a)), closes [opensearch-project#1087](elastic/elastic-charts#1087)

### Features

* **a11y:** allow user to pass custom description for screen readers ([opensearch-project#1111](elastic/elastic-charts#1111)) ([a0020ba](elastic/elastic-charts@a0020ba)), closes [#1097](elastic/elastic-charts#1097)
* **partition:** add debuggable state ([opensearch-project#1117](elastic/elastic-charts#1117)) ([08f8baf](elastic/elastic-charts@08f8baf)), closes [opensearch-project#917](elastic/elastic-charts#917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants