Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unit test opt_in_banner.test.tsx is skipped now #516

Closed
ananzh opened this issue Jun 21, 2021 · 0 comments · Fixed by #532
Closed

[Test] unit test opt_in_banner.test.tsx is skipped now #516

ananzh opened this issue Jun 21, 2021 · 0 comments · Fixed by #532
Assignees
@ananzh
Labels
test:unit v1.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jun 21, 2021

Describe the bug

Currently, opt_in_banner.test.tsx test suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.

/src/plugins/telemetry/public/components/opt_in_banner.test.tsx
Test Suites: 1 skipped, 0 of 1 total
Tests:       3 skipped, 3 total

To Reproduce
Run:yarn test:jest {path to opt_in_banner.test.tsx}

Expected behavior
explore the skipped unit tests, check:

  • can we enable all? if yes, create a PR and close the issue

  • can we remove all? if yes, create a PR and close the issue

  • should we keep all? if yes, describe the reasons in the issue.

The final output is expected to be a cleaned unit test with all the skipped ones being checked.

OpenSearch Version
OpenSearch 1.0.0

Dashboards Version
Dashboards 1.0.0
@ananzh ananzh self-assigned this Jun 21, 2021
@ananzh ananzh mentioned this issue Jun 22, 2021
Closed
26 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 22, 2021
@ananzh
[Test] Enable unit test suite:opt_in_banner.test.tsx (opensearch-proj…
d66fb64 
…ect#516)

All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
opt_in_banner.test.tsx.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Jun 22, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request Jun 23, 2021 that will close this issue
[Test] Enable unit test suites in telemetry/public/components #532
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
test:unit v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test] Enable unit test suites in telemetry/public/components ananzh/OpenSearch-Dashboards
1 participant
@ananzh