Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard De-Angular] Query, filter and time range correctly update child embeddables #4362

Closed
Tracked by #4002
abbyhu2000 opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
dashboards de-angular de-angularize work

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Jun 22, 2023

  • Query, filters(global filters + app filters) + time filters(time range + time refresh config) should be correctly updating child visualization embeddables.
  • query and app filter being persisted app wise; time filter and global filter being persisted globally across dashboards.
  • they also need to be correctly saved and stored in state container, dashboard container and osd URL storage.
@abbyhu2000 abbyhu2000 changed the title query, filter and time range correctly update child embeddables [Dashboard De-Angular] Query, filter and time range correctly update child embeddables Jun 22, 2023
@abbyhu2000 abbyhu2000 self-assigned this Jun 22, 2023
@abbyhu2000 abbyhu2000 added dashboards de-angular de-angularize work and removed untriaged labels Jun 22, 2023
@abbyhu2000
Copy link
Member Author

  1. AppState/state container will only store information for global filter and query
  2. Time filter and global filter will be only stored in the URL, they will not be stored in AppState/state container; but they will need to be stored in dashboard container, since dashboard container embeddable needs them to update the child embeddable.

@abbyhu2000
Copy link
Member Author

abbyhu2000 commented Jun 22, 2023

Previous logic for time filter:

  1. The default for time filter.
  2. Add subscription to the time change, and call refreshDashboardContainer().
  3. it will call getChangesFromAppStateForContainerState(), call appStateDashboardInput() have the latest time range and refreshConfig.
  4. Once we get the differences for timeRange, then we go update input for dashboard container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboards de-angular de-angularize work
Projects
None yet
Development

No branches or pull requests

1 participant