Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-46175 (High) detected in json5-1.0.1.tgz, json5-2.2.1.tgz - autoclosed #3148

Closed
mend-for-github-com bot opened this issue Dec 25, 2022 · 4 comments
Assignees
Labels
high severity High severity CVE Mend: dependency security vulnerability Security vulnerability detected by Mend v2.5.0 'Issues and PRs related to version v2.5.0'

Comments

@mend-for-github-com
Copy link

mend-for-github-com bot commented Dec 25, 2022

CVE-2022-46175 - High Severity Vulnerability

Vulnerable Libraries - json5-1.0.1.tgz, json5-2.2.1.tgz

json5-1.0.1.tgz

JSON for humans.

Library home page: https://registry.npmjs.org/json5/-/json5-1.0.1.tgz

Dependency Hierarchy:

  • json5-1.0.1.tgz (Vulnerable Library)
json5-2.2.1.tgz

JSON for humans.

Library home page: https://registry.npmjs.org/json5/-/json5-2.2.1.tgz

Dependency Hierarchy:

  • core-7.17.8.tgz (Root Library)
    • json5-2.2.1.tgz (Vulnerable Library)

Found in HEAD commit: cba076465f44b6a819e3cff7986ff4cd21a66371

Found in base branch: main

Vulnerability Details

JSON5 is an extension to the popular JSON file format that aims to be easier to write and maintain by hand (e.g. for config files). The parse method of the JSON5 library before and including versions 1.0.1 and 2.2.1 does not restrict parsing of keys named __proto__, allowing specially crafted strings to pollute the prototype of the resulting object. This vulnerability pollutes the prototype of the object returned by JSON5.parse and not the global Object prototype, which is the commonly understood definition of Prototype Pollution. However, polluting the prototype of a single object can have significant security impact for an application if the object is later used in trusted operations. This vulnerability could allow an attacker to set arbitrary and unexpected keys on the object returned from JSON5.parse. The actual impact will depend on how applications utilize the returned object and how they filter unwanted keys, but could include denial of service, cross-site scripting, elevation of privilege, and in extreme cases, remote code execution. JSON5.parse should restrict parsing of __proto__ keys when parsing JSON strings to objects. As a point of reference, the JSON.parse method included in JavaScript ignores __proto__ keys. Simply changing JSON5.parse to JSON.parse in the examples above mitigates this vulnerability. This vulnerability is patched in json5 versions 1.0.2, 2.2.2, and later.

Publish Date: 2022-12-24

URL: CVE-2022-46175

CVSS 3 Score Details (8.8)

Base Score Metrics:

  • Exploitability Metrics:
    • Attack Vector: Network
    • Attack Complexity: Low
    • Privileges Required: Low
    • User Interaction: None
    • Scope: Unchanged
  • Impact Metrics:
    • Confidentiality Impact: High
    • Integrity Impact: High
    • Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Origin: https://www.cve.org/CVERecord?id=CVE-2022-46175

Release Date: 2022-12-24

Fix Resolution (json5): 2.2.2

Direct dependency fix Resolution (@babel/core): 7.17.9

@mend-for-github-com mend-for-github-com bot added the Mend: dependency security vulnerability Security vulnerability detected by Mend label Dec 25, 2022
@seanneumann seanneumann added high severity High severity CVE v2.5.0 'Issues and PRs related to version v2.5.0' and removed untriaged labels Dec 29, 2022
@seanneumann
Copy link
Contributor

Let's get this upgraded to 2.2.2.

@kavilla
Copy link
Member

kavilla commented Jan 3, 2023

yarn why json5
yarn why v1.22.19
[1/4] Why do we have the module "json5"...?
[2/4] Initialising dependency graph...
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~4.5.2"
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "json5@1.0.1"
info Has been hoisted to "json5"
info Reasons this module exists
   - "workspace-aggregator-b95ebf2d-3958-4412-a639-46283d804c65" depends on it
   - Specified in "devDependencies"
   - Hoisted from "_project_#json5"
   - Hoisted from "_project_#eslint-plugin-import#tsconfig-paths#json5"
info Disk size without dependencies: "124KB"
info Disk size with unique dependencies: "228KB"
info Disk size with transitive dependencies: "228KB"
info Number of shared dependencies: 1
=> Found "@babel/core#json5@2.2.1"
info This module exists because "_project_#@babel#core" depends on it.
info Disk size without dependencies: "288KB"
info Disk size with unique dependencies: "288KB"
info Disk size with transitive dependencies: "288KB"
info Number of shared dependencies: 0
=> Found "loader-utils#json5@2.2.1"
info This module exists because "_project_#@osd#ui-shared-deps#loader-utils" depends on it.
info Disk size without dependencies: "288KB"
info Disk size with unique dependencies: "288KB"
info Disk size with transitive dependencies: "288KB"
info Number of shared dependencies: 0
Done in 1.06s.

@BSFishy
Copy link
Contributor

BSFishy commented Jan 4, 2023

We fixed this in OUI in this PR: opensearch-project/oui#179

An interesting note, some vulnerability reporting services report that 1.0.2 does not have the vulnerability fixed, however the fix was indeed backported to 1.0.2. It seems that these services need to fix their audits.

@BSFishy BSFishy assigned BSFishy and unassigned AbhishekReddy1127 Jan 6, 2023
@mend-for-github-com mend-for-github-com bot changed the title CVE-2022-46175 (High) detected in json5-1.0.1.tgz, json5-2.2.1.tgz CVE-2022-46175 (High) detected in json5-1.0.1.tgz, json5-2.2.1.tgz - autoclosed Jan 6, 2023
@mend-for-github-com
Copy link
Author

✔️ This issue was automatically closed by Mend because the vulnerable library in the specific branch(es) was either marked as ignored or it is no longer part of the Mend inventory.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jan 26, 2023
…d 2.2.3

Backport PR: opensearch-project#3201
Issue Resolved:
opensearch-project#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jan 26, 2023
Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: opensearch-project#3201
Issue Resolved:
opensearch-project#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jan 26, 2023
Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: opensearch-project#3201
Issue Resolved:
opensearch-project#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jan 26, 2023
Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: opensearch-project#3201
Issue Resolved:
opensearch-project#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this issue Jan 27, 2023
…#3335)

Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: #3201
Issue Resolved:
#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 27, 2023
…#3335)

Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: #3201
Issue Resolved:
#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 0cc894a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh added a commit that referenced this issue Jan 27, 2023
…#3337)

Bumps json5 version from 1.0.1 and 2.2.1 to 1.0.2 and 2.2.3

Backport PR: #3201
Issue Resolved:
#3148

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high severity High severity CVE Mend: dependency security vulnerability Security vulnerability detected by Mend v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

No branches or pull requests

4 participants