Skip to content

Commit

Permalink
[OSCI] [FIX] time conversion unit test bug (#5174)
Browse files Browse the repository at this point in the history
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <lechithanh2003@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
  • Loading branch information
4 people authored Oct 4, 2023
1 parent 7207635 commit 336dce6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fix errors in conditions for activating `vizAugmenter` ([#5213](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5213))
- [Data Explorer][Discover] Automatically load solo added default index pattern ([#5171](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5171))
- [Data Explorer][Discover] Allow data grid to auto adjust size based on fetched data count ([#5191](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5191))
- [BUG] Fix wrong test due to time conversion ([#5174](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5174))
- [BUG][Data Explorer][Discover] Allow filter and query persist when refresh page or paste url to a new tab ([#5206](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5206))


### 🚞 Infrastructure

- Re-enable CI workflows for feature branches ([#2908](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2908))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ describe('buildPointSeriesData', () => {
expect(result.ordered.interval.asHours()).toBe(1);
expect(result.ordered.intervalOpenSearchUnit).toBe('h');
expect(result.ordered.intervalOpenSearchValue).toBe(1);
expect(result.ordered.min.format()).toBe('2023-01-01T00:00:00+00:00');
expect(result.ordered.max.format()).toBe('2023-01-02T00:00:00+00:00');
expect(result.ordered.min.format()).toBe(moment('2023-01-01T00:00:00+00:00').format());
expect(result.ordered.max.format()).toBe(moment('2023-01-02T00:00:00+00:00').format());
expect(result.yAxisLabel).toEqual('Y Axis');
expect(result.values).toEqual([
{ x: 10, y: 100 },
Expand Down

0 comments on commit 336dce6

Please sign in to comment.