Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFTWARE-5448: Exit the supervisord init process if squid exits #187

Conversation

mwestphall
Copy link
Contributor

@mwestphall mwestphall commented Jun 3, 2024

A closed issue in supervisord recommends sending a SIGINT to supervisord at the end of a supervised process as a potential approach for exiting on the exit of the service: Supervisor/supervisor#712 Since supervisord is the init process of this container, the whole container will exit if the waited-on squid process ends in start-frontier-squid.sh

Copy link
Contributor

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, interesting. Note that if squid (or $STARTSTOPSCRIPT) fails then this means supervisord won't restart it -- but we already throw away the exit code with the wait trick so I guess it would happen anyway.

@mwestphall
Copy link
Contributor Author

OK, interesting. Note that if squid (or $STARTSTOPSCRIPT) fails then this means supervisord won't restart it -- but we already throw away the exit code with the wait trick so I guess it would happen anyway.

That might be an item to discuss - The ticket that suggests this change is somewhat ambiguous about when supervisord should shut down. Does it make sense for the whole container to exit if squid exits a single time (as in this change), or only after supervisord fails to recover the process?

@mwestphall mwestphall merged commit 8edc5ff into opensciencegrid:main Jun 4, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants