refactor: Order imports #4496
Merged
refactor: Order imports #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.OrderImports?organizationId=T3BlblJld3JpdGU%3D#defaults=W3sidmFsdWUiOiJUcnVlIiwibmFtZSI6InJlbW92ZVVudXNlZCJ9XQ== Co-authored-by: Moderne <team@moderne.io>
timtebeek
commented
Sep 16, 2024
rewrite-core/src/test/java/org/openrewrite/internal/StringUtilsTest.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Sep 16, 2024
rewrite-maven/src/test/java/org/openrewrite/maven/AddRuntimeConfigTest.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Sep 16, 2024
There was a problem hiding this comment.
I think it's fine to change these generated classes just this once, such that going forward we can enforce this recipe.
|
Note that I'm not necessarily saying you should change the recipe still; just calling out the effects on this project after your changes. It looks much better than it did before already now that nested imports are handled better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Laurens-W
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.OrderImports?organizationId=T3BlblJld3JpdGU%3D#defaults=W3sidmFsdWUiOiJUcnVlIiwibmFtZSI6InJlbW92ZVVudXNlZCJ9XQ==