Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: profile specific plugins were not matched #3967

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: profile specific plugins were not matched #3967

merged 1 commit into from
Feb 2, 2024

Conversation

dpozinen
Copy link
Contributor

@dpozinen dpozinen commented Feb 2, 2024

fixes #3966

@timtebeek timtebeek self-requested a review February 2, 2024 14:48
@timtebeek timtebeek added the enhancement New feature or request label Feb 2, 2024
timtebeek
timtebeek approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work on this @dpozinen ! Looks good to me already; we'll await the tests results and get this merged.

@timtebeek timtebeek merged commit 605faae into openrewrite:main Feb 2, 2024
1 check passed
@timtebeek
Copy link
Contributor

Thanks again! This will roll out to our snapshot versions soon, and you can try it out from there before the next release:
https://docs.openrewrite.org/reference/snapshot-instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@dpozinen dpozinen

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChangePluginGroupIdAndArtifactId ignores profile specific plugins
2 participants
@dpozinen @timtebeek