Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add by to forwarded headers in reverse proxy #176

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add by to forwarded headers in reverse proxy #176

wants to merge 3 commits into from

Conversation

goughlee
Copy link
Contributor

@goughlee goughlee commented Mar 27, 2019 •
edited
Loading

Set by identifier to Owin provided server.localIpAddress if available.
Fall back to _machinename if server.localIpAddress is not available.
Added ByIdentifierOverride option to allow setting the ByIdentifier manually at config time.

@goughlee goughlee requested a review from serialseb March 27, 2019 12:02
@serialseb
Copy link
Member

Side note, if you could rebase that'd fix the build errors

@goughlee
Copy link
Contributor Author

Have simplified this greatly now. It uses server.localIpAddress if it's there, else it uses _machinename. Also added config option to allow manual setting of ByIdentifier at config time.

@goughlee goughlee requested a review from serialseb March 29, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serialseb serialseb Awaiting requested review from serialseb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goughlee @serialseb