AC-838 Updated UI for active visits card view #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making location text color, Dark Green was troubling dark mode UI as it was not visible, so I used standard colors which are compatible with both light-dark mode
|
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
+ Coverage 13.49% 13.64% +0.15%
==========================================
Files 238 237 -1
Lines 9659 9549 -110
Branches 924 916 -8
==========================================
Hits 1303 1303
+ Misses 8250 8140 -110
Partials 106 106
Continue to review full report at Codecov.
|
f4ww4z
reviewed
Aug 22, 2020
There was a problem hiding this comment.
@rishabh-997 Please change the birth date to the visit's startDatetime, and see my other comment.
.../src/main/java/org/openmrs/mobile/activities/activevisits/ActiveVisitsRecyclerViewAdapter.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openmrs/mobile/activities/activevisits/ActiveVisitsRecyclerViewAdapter.kt
Outdated
Show resolved
Hide resolved
AC-838 Updated UI for active visits card view AC-838 Updated UI for active visits card view
rishabh-997
force-pushed
the
AC-838-visitCardUI
branch
from
7335027
to
42f9786
Compare
LuGO0
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-838
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)