Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-841 Migrated Chart List Adapter to Recycler View #807

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-841

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

WhatsApp Image 2020-08-20 at 3 01 27 AM

@codecov-commenter
Copy link

Codecov Report

Merging #807 into master will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   13.49%   13.65%   +0.16%     
==========================================
  Files         238      237       -1     
  Lines        9659     9545     -114     
  Branches      924      914      -10     
==========================================
  Hits         1303     1303              
+ Misses       8250     8136     -114     
  Partials      106      106              
Impacted Files Coverage Δ
...es/patientdashboard/charts/ChartsViewActivity.java 0.00% <ø> (ø)
...patientdashboard/charts/PatientChartsFragment.java 0.00% <0.00%> (ø)
...board/charts/PatientChartsRecyclerViewAdapter.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4ad94...8407f68. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit fc856ec into openmrs:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants