Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-664 Added Notification channel for higher API levels #795

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-664

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997 rishabh-997 requested a review from f4ww4z August 2, 2020 06:22
@codecov-commenter
Copy link

Codecov Report

Merging #795 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   13.87%   13.86%   -0.01%     
==========================================
  Files         227      227              
  Lines        9231     9236       +5     
  Branches      890      891       +1     
==========================================
  Hits         1281     1281              
- Misses       7851     7856       +5     
  Partials       99       99              
Impacted Files Coverage Δ
...penmrs/mobile/services/ConceptDownloadService.java 0.00% <0.00%> (ø)
...g/openmrs/mobile/utilities/ApplicationConstants.kt 9.52% <0.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f38ab9...6e4562a. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @rishabh-997

@f4ww4z f4ww4z merged commit feb5c00 into openmrs:master Aug 3, 2020
@rishabh-997 rishabh-997 deleted the AC-664-notification branch August 19, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants