Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-824 Fixed Release version blocker #790

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Disabled minifyEnabled which increased app size by 3mb
  2. Removed SQL-cipher which decreased app size by 5mb

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-824

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997 rishabh-997 requested a review from f4ww4z July 30, 2020 17:34
force restarting build

AC-824 Fixed Release verion for app
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rishabh-997 !

@f4ww4z f4ww4z merged commit 5f38ab9 into openmrs:master Aug 1, 2020
@rishabh-997 rishabh-997 deleted the expe branch August 19, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants