Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-814 Updated UI for Patient dashboard details screen #785

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Removed the bigger image view
  2. Made UI bit more precise
  3. removed newly created unused resources

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-814

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

rishabh-997 commented Jul 26, 2020

WhatsApp Image 2020-07-27 at 12 52 20 AM

After so many new UI and refactors, I thought to inspect code for unused resources and turns out that there are many, so I am reopening this issue, can you get this ready :
https://issues.openmrs.org/browse/AC-596

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020

Codecov Report

Merging #785 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   13.78%   13.78%           
=======================================
  Files         224      224           
  Lines        9179     9176    -3     
  Branches      883      884    +1     
=======================================
  Hits         1265     1265           
+ Misses       7816     7813    -3     
  Partials       98       98           
Impacted Files Coverage Δ
...ies/patientdashboard/PatientDashboardActivity.java 0.00% <0.00%> (ø)
...tientdashboard/details/PatientDetailsFragment.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba5b26...728bc29. Read the comment docs.

@HerbertYiga
Copy link

cc @f4ww4z

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@rishabh-997 If in dark mode, the current selected tab's text cannot be seen, please change it to bold white color.

Also the tabs doesn't match with the preferred material design like this and this . I think keep the background color as green and change font colors to white and light grey.

@rishabh-997
Copy link
Collaborator Author

WhatsApp Image 2020-07-28 at 12 29 19 PM (1)

Copy link
Collaborator

@LuGO0 LuGO0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new change LGTM @rishabh-997

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 Looks great.

@f4ww4z f4ww4z merged commit f9b845e into openmrs:master Jul 29, 2020
@rishabh-997 rishabh-997 deleted the AC-814-patientDashboardUI branch July 29, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants