-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-814 Updated UI for Patient dashboard details screen #785
Conversation
After so many new UI and refactors, I thought to inspect code for unused resources and turns out that there are many, so I am reopening this issue, can you get this ready : |
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 13.78% 13.78%
=======================================
Files 224 224
Lines 9179 9176 -3
Branches 883 884 +1
=======================================
Hits 1265 1265
+ Misses 7816 7813 -3
Partials 98 98
Continue to review full report at Codecov.
|
cc @f4ww4z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 If in dark mode, the current selected tab's text cannot be seen, please change it to bold white color.
Also the tabs doesn't match with the preferred material design like this and this . I think keep the background color as green and change font colors to white and light grey.
84e9389
to
728bc29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this new change LGTM @rishabh-997
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 Looks great.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-814
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)