Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC 804 Added Allergy Tab to fetch allergies from server #780

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Added new tab in the dashboard
  2. Created rest calls to fetch data
  3. Added kotlin data classes
  4. Added an abstraction layer in presenter
  5. Added appropriate tests

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-804

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #780 into master will increase coverage by 0.15%.
The diff coverage is 25.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   11.85%   12.00%   +0.15%     
==========================================
  Files         255      262       +7     
  Lines       11063    11173     +110     
  Branches     1130     1138       +8     
==========================================
+ Hits         1311     1341      +30     
- Misses       9653     9733      +80     
  Partials       99       99              
Impacted Files Coverage Δ
...ies/patientdashboard/PatientDashboardActivity.java 0.00% <0.00%> (ø)
...patientdashboard/PatientDashboardPagerAdapter.java 0.00% <0.00%> (ø)
...ard/allergy/PatientAllergyRecyclerViewAdapter.java 0.00% <0.00%> (ø)
.../java/org/openmrs/mobile/models/AllergyReaction.kt 0.00% <0.00%> (ø)
...g/openmrs/mobile/utilities/ApplicationConstants.kt 10.00% <0.00%> (-0.53%) ⬇️
...tientdashboard/allergy/PatientAllergyFragment.java 3.57% <3.57%> (ø)
...rc/main/java/org/openmrs/mobile/models/Allergen.kt 33.33% <33.33%> (ø)
...oard/allergy/PatientDashboardAllergyPresenter.java 52.38% <52.38%> (ø)
...enmrs/mobile/api/repository/AllergyRepository.java 76.92% <76.92%> (ø)
...src/main/java/org/openmrs/mobile/models/Allergy.kt 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d4b9e...fd634dd. Read the comment docs.

@rishabh-997
Copy link
Collaborator Author

Do add the allergies on the server before testing the changes... @LuGO0 @f4ww4z sir

WhatsApp Image 2020-07-11 at 3 03 25 AM

created layouts for allergies

added models and api path

resolving conflicts

changed modela classes to kotlin

added repository and tests

AC-804 Updated string values and variable names

added tab count in application constatnt

removed star imports

AC-804 Added allergy module base in the project
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @rishabh-997

@f4ww4z f4ww4z merged commit 6fdffec into openmrs:master Jul 14, 2020
@rishabh-997 rishabh-997 deleted the AC-804-allergy-view branch July 14, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants