Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-796 Updated UI for synced patient cards #778

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-796

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

rishabh-997 commented Jul 7, 2020

An error java.lang.IllegalArgumentException: Bitmap could not be decoded from the Uri shows up while adding patient photos which i will look into in a separate issue. So I was not able to test UI with patient photos.
86754397-7aec8080-c05e-11ea-81ad-5329dc675a76-min (1)

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #778 into master will increase coverage by 0.02%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   11.82%   11.85%   +0.02%     
==========================================
  Files         255      255              
  Lines       11083    11063      -20     
  Branches     1126     1130       +4     
==========================================
  Hits         1311     1311              
+ Misses       9673     9653      -20     
  Partials       99       99              
Impacted Files Coverage Δ
...ivities/addeditpatient/AddEditPatientFragment.java 0.00% <0.00%> (ø)
...tientdashboard/details/PatientDetailsFragment.java 0.00% <0.00%> (ø)
...patientdashboard/visits/PatientVisitsFragment.java 0.00% <0.00%> (ø)
...cedpatients/SyncedPatientsRecyclerViewAdapter.java 0.00% <0.00%> (ø)
...c/main/java/org/openmrs/mobile/dao/PatientDAO.java 0.00% <0.00%> (ø)
...ava/org/openmrs/mobile/databases/DBOpenHelper.java 11.53% <0.00%> (-0.10%) ⬇️
.../main/java/org/openmrs/mobile/models/PatientDto.kt 40.00% <0.00%> (ø)
...rc/main/java/org/openmrs/mobile/models/Person.java 78.43% <ø> (ø)
...g/openmrs/mobile/utilities/ApplicationConstants.kt 10.52% <ø> (ø)
...c/main/java/org/openmrs/mobile/models/Patient.java 47.27% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e235432...4428ead. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 See my comments.

@rishabh-997
Copy link
Collaborator Author

IMG_20200709_001814

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @rishabh-997

@f4ww4z f4ww4z merged commit 71d4b9e into openmrs:master Jul 10, 2020
@rishabh-997 rishabh-997 deleted the AC-796-syncedcardUI branch July 14, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants