-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-802: Small UI fix for contact Us screen #777
Conversation
The UI after change @f4ww4z @rishabh-997 please review |
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 11.69% 11.85% +0.15%
==========================================
Files 251 255 +4
Lines 10898 11055 +157
Branches 1108 1126 +18
==========================================
+ Hits 1275 1311 +36
- Misses 9524 9645 +121
Partials 99 99
Continue to review full report at Codecov.
|
I feel OR looks good. Can coordinator layout help pushing the layout above when snackbar pops up ? Else the PR is fine. |
@rishabh yes I tried that as well but the scroll view gets chopped off at the beginning so it again dosent looks good so I decided to remove "OR" |
@LuGO0 Still keep the 'OR', but lower the image to about 60% of the screen width or until everything fits on the screen without needing to scroll. Also change the PR title to the JIRA issue title. See our PR tips |
1. added required elevation 2. fixed the vertical biases 3. snackbar doesnt hide any text now
@LuGO0 Did you forget the ticket number? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-802
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)