Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-802: Small UI fix for contact Us screen #777

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

LuGO0
Copy link
Collaborator

@LuGO0 LuGO0 commented Jul 6, 2020

Description of what I changed

  1. added required elevation
  2. removed or text
  3. snackbar doesnt hide any text now

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-802

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@LuGO0
Copy link
Collaborator Author

LuGO0 commented Jul 6, 2020

The UI after change @f4ww4z @rishabh-997 please review

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #777 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   11.69%   11.85%   +0.15%     
==========================================
  Files         251      255       +4     
  Lines       10898    11055     +157     
  Branches     1108     1126      +18     
==========================================
+ Hits         1275     1311      +36     
- Misses       9524     9645     +121     
  Partials       99       99              
Impacted Files Coverage Δ
...vities/addeditpatient/AddEditPatientPresenter.java 40.10% <0.00%> (-5.35%) ⬇️
...ava/org/openmrs/mobile/databases/DBOpenHelper.java 11.63% <0.00%> (-0.42%) ⬇️
...c/main/java/org/openmrs/mobile/dao/PatientDAO.java 0.00% <0.00%> (ø)
...g/openmrs/mobile/utilities/ApplicationConstants.kt 10.52% <0.00%> (ø)
.../openmrs/mobile/databases/tables/PatientTable.java 21.42% <0.00%> (ø)
...penmrs/mobile/api/workers/UpdatePatientWorker.java 0.00% <0.00%> (ø)
...enmrs/mobile/api/repository/PatientRepository.java 12.88% <0.00%> (ø)
...ivities/addeditpatient/AddEditPatientFragment.java 0.00% <0.00%> (ø)
...es/matchingpatients/MatchingPatientsPresenter.java 71.66% <0.00%> (ø)
...patientdashboard/visits/PatientVisitsFragment.java 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f7980...aece20a. Read the comment docs.

@rishabh-997
Copy link
Collaborator

rishabh-997 commented Jul 7, 2020

I feel OR looks good. Can coordinator layout help pushing the layout above when snackbar pops up ? Else the PR is fine.

@LuGO0
Copy link
Collaborator Author

LuGO0 commented Jul 7, 2020

I feel OR looks good. Can coordinator layout help pushing the layout above when snackbar pops up ? Else the PR is fine.

@rishabh yes I tried that as well but the scroll view gets chopped off at the beginning so it again dosent looks good so I decided to remove "OR"

@f4ww4z
Copy link
Collaborator

f4ww4z commented Jul 8, 2020

@LuGO0 Still keep the 'OR', but lower the image to about 60% of the screen width or until everything fits on the screen without needing to scroll.

Also change the PR title to the JIRA issue title. See our PR tips

@LuGO0
Copy link
Collaborator Author

LuGO0 commented Jul 8, 2020

@LuGO0 Still keep the 'OR', but lower the image to about 60% of the screen width or until everything fits on the screen without needing to scroll.

Also change the PR title to the JIRA issue title. See our PR tips

okay @f4ww4z I would do this

@LuGO0 LuGO0 changed the title fixed small UI bug Small UI fix for contact Us screen Jul 8, 2020
1. added required elevation
2. fixed the vertical biases
3. snackbar doesnt hide any text now
@f4ww4z
Copy link
Collaborator

f4ww4z commented Jul 10, 2020

@LuGO0 Did you forget the ticket number?

@f4ww4z f4ww4z changed the title Small UI fix for contact Us screen AC-802: Small UI fix for contact Us screen Jul 10, 2020
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f4ww4z f4ww4z merged commit 6672191 into openmrs:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants