AC-791 Updated UI of registeration screen #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 11.80% 11.85% +0.04%
==========================================
Files 254 254
Lines 10926 10886 -40
Branches 1091 1092 +1
==========================================
Hits 1290 1290
+ Misses 9548 9508 -40
Partials 88 88
Continue to review full report at Codecov.
|
LuGO0
approved these changes
Jun 24, 2020
openmrs-client/src/main/java/org/openmrs/mobile/activities/logs/LogsFragment.kt
Outdated
Show resolved
Hide resolved
rishabh-997
force-pushed
the
AC-791-registerUI
branch
from
75bd6a2
to
e679c93
Compare
f4ww4z
reviewed
Jun 27, 2020
There was a problem hiding this comment.
@rishabh-997 I helped you with the merge conflict, just see my comments to clean up this PR.
Comment on lines
112
to
113
| private final static int IMAGE_REQUEST = 1; | ||
| private final static int GALLERY_IMAGE_REQUEST = 2; |
There was a problem hiding this comment.
Remove these as they're in ApplicationConstants now.
...lient/src/main/java/org/openmrs/mobile/activities/addeditpatient/AddEditPatientFragment.java
Show resolved
Hide resolved
rishabh-997
force-pushed
the
AC-791-registerUI
branch
from
17c98f8
to
4af72d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-791
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)