Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-788 Added crop image feature at registration screen #768

Merged
merged 4 commits into from
Jun 27, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Added the library
  2. Added storage permission checks while selecting the photo from the gallery
  3. Removed the code to process images from gallery and updated it with new one

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-788

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@HerbertYiga
Copy link

@rishabh-997 thanks for working on this,got some failing tests on ci,you could checkout the ci logs

@rishabh-997
Copy link
Collaborator Author

@rishabh-997 thanks for working on this,got some failing tests on ci,you could checkout the ci logs

There was some strange Kotlin error from the previous PR. Interestingly, they did not appear in the previous PR and suddenly appear in successive ones.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #768 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   11.81%   11.80%   -0.01%     
==========================================
  Files         254      254              
  Lines       10918    10926       +8     
  Branches     1087     1091       +4     
==========================================
  Hits         1290     1290              
- Misses       9540     9548       +8     
  Partials       88       88              
Impacted Files Coverage Δ
...ivities/addeditpatient/AddEditPatientFragment.java 0.00% <0.00%> (ø)
...openmrs/mobile/utilities/ApplicationConstants.java 5.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2616d13...e94d453. Read the comment docs.

@LuGO0
Copy link
Collaborator

LuGO0 commented Jun 22, 2020

@rishabh this error must have popped up due to some open Open Issue in kotlin java interop. where there is one more workaround that you can mark that field as @Jvmfield :)

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 Just a few comments to take care of.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 I'm not able to access UCrop's feature, see the recording at https://imgur.com/a/z3QEmqx . Tested on API level 21 and 30.

I think there's a problem with the outdated way of getting URI from a file using Uri.fromFile , we should use AndroidX's way of getting it by using FileProvider.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit 2026930 into openmrs:master Jun 27, 2020
@rishabh-997 rishabh-997 deleted the AC-788-crop branch July 14, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants