AC-776 Migrated Logs activity to kotlin #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 11.72% 11.73% +0.01%
==========================================
Files 249 249
Lines 10770 10759 -11
Branches 1036 1036
==========================================
Hits 1263 1263
+ Misses 9424 9413 -11
Partials 83 83
Continue to review full report at Codecov.
|
LuGO0
requested changes
Jun 16, 2020
|
|
||
| private lateinit var _binding: FragmentLogsBinding | ||
|
|
||
| override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, |
There was a problem hiding this comment.
@rishabh-997 can we do away with the underscore is it necessary ??
There was a problem hiding this comment.
It is a practice followed in kotlin where unused variables are marked as _... As suggested by Android Studio
LuGO0
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-776
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)