AC-768: Added adjustResize to avoid soft keyboard to block snackbar messages #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 11.75% 11.75%
=======================================
Files 238 238
Lines 10655 10655
Branches 1028 1028
=======================================
Hits 1252 1252
Misses 9321 9321
Partials 82 82 Continue to review full report at Codecov.
|
VibhorChinda
approved these changes
May 22, 2020
|
@Rec0iL99 LGTM 👍 |
LuGO0
approved these changes
May 22, 2020
f4ww4z
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Added adjustResize instead of adjustPan in windowSoftInputMode attribute for LoginActivity in manifest file.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-768
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.