Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-767 Removed FontUtil and updated fonts to Roboto #745

Merged
merged 1 commit into from
May 25, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Removed FontUtil.java
  2. Refactored code where FontUtil.java was used
  3. Updated XML files that were affected by FontUtil.java
  4. Removed all Open-Sans.tff and replaced them with few Roboto.tff which might be called explicitly during UI update in future

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-767

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #745 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   11.75%   11.83%   +0.08%     
==========================================
  Files         238      237       -1     
  Lines       10655    10576      -79     
  Branches     1028     1018      -10     
==========================================
  Hits         1252     1252              
+ Misses       9321     9242      -79     
  Partials       82       82              
Impacted Files Coverage Δ
.../activities/activevisits/ActiveVisitsFragment.java 0.00% <ø> (ø)
.../activevisits/ActiveVisitsRecyclerViewAdapter.java 0.00% <ø> (ø)
...ditpatient/SimilarPatientsRecyclerViewAdapter.java 0.00% <ø> (ø)
...mobile/activities/dashboard/DashboardFragment.java 0.00% <ø> (ø)
...mobile/activities/dialog/CustomFragmentDialog.java 0.00% <ø> (ø)
...mentrypatientlist/FormEntryPatientListAdapter.java 0.00% <ø> (ø)
...entrypatientlist/FormEntryPatientListFragment.java 0.00% <ø> (ø)
...patients/LastViewedPatientRecyclerViewAdapter.java 0.00% <ø> (ø)
...openmrs/mobile/activities/login/LoginFragment.java 4.29% <ø> (+0.01%) ⬆️
...ies/matchingpatients/MatchingPatientsFragment.java 0.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c945a...3a53942. Read the comment docs.

@HerbertYiga
Copy link

@rishabh-997 thanks for working on this,you can also add a ticket ID on your commit message

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rishabh-997 , see above comment next time.

@f4ww4z f4ww4z merged commit 96ed495 into openmrs:master May 25, 2020
@rishabh-997 rishabh-997 deleted the AC-767-FontUtils branch May 30, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants