Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-745 fixed the transition error upon language change #741

Merged
merged 1 commit into from
May 18, 2020

Conversation

LuGO0
Copy link
Collaborator

@LuGO0 LuGO0 commented May 15, 2020

Description of what I changed

  1. I changed the ACBaseActivity to start settings activity for a result and checked if it results ok then
    after the settings activity returns I recreate the dashboard activity

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-745

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #741 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
- Coverage   11.78%   11.77%   -0.01%     
==========================================
  Files         238      238              
  Lines       10612    10621       +9     
  Branches     1022     1023       +1     
==========================================
  Hits         1251     1251              
- Misses       9280     9289       +9     
  Partials       81       81              
Impacted Files Coverage Δ
.../org/openmrs/mobile/activities/ACBaseActivity.java 0.00% <0.00%> (ø)
...s/mobile/activities/settings/SettingsActivity.java 0.00% <0.00%> (ø)
...s/mobile/activities/settings/SettingsFragment.java 0.00% <0.00%> (ø)
...openmrs/mobile/utilities/ApplicationConstants.java 5.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3116338...176cc4c. Read the comment docs.

@LuGO0
Copy link
Collaborator Author

LuGO0 commented May 15, 2020

@f4ww4z please review !!

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @LuGO0

@f4ww4z f4ww4z merged commit 8050c55 into openmrs:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants