Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-757 Fixed EncounterRoomDAO tests #740

Merged
merged 1 commit into from
May 15, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

The test for getAllEncountersByType was completely wrong and had to do significant changes to pass this test.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-754

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #740 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   11.82%   11.78%   -0.04%     
==========================================
  Files         237      238       +1     
  Lines       10583    10614      +31     
  Branches     1019     1021       +2     
==========================================
  Hits         1251     1251              
- Misses       9251     9282      +31     
  Partials       81       81              
Impacted Files Coverage Δ
...activities/dialog/CameraOrGalleryPickerDialog.java 0.00% <0.00%> (ø)
...ivities/addeditpatient/AddEditPatientFragment.java 0.00% <0.00%> (ø)
...rs/mobile/activities/dialog/CustomDialogModel.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cfd9a...688dcf7. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit 3778fdf into openmrs:master May 15, 2020
@rishabh-997 rishabh-997 deleted the AC-754-encounter branch May 19, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants