Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-758 Fixed VisitRoomDAO tests #738

Merged
merged 4 commits into from
May 18, 2020
Merged

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-758

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997 rishabh-997 changed the title AC-758 Fixed visitRoomDAO tests AC-758 Fixed VisitRoomDAO tests May 12, 2020
@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #738 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   11.76%   11.76%           
=======================================
  Files         238      238           
  Lines       10646    10646           
  Branches     1027     1027           
=======================================
  Hits         1252     1252           
  Misses       9312     9312           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3778fdf...f25e8af. Read the comment docs.

@VibhorChinda
Copy link
Collaborator

LGTM :)

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 Can you create a helper function to compare the equality of 2 VisitEntity objects? Like you did at #739 . It will make the code a lot easier and remove repetition.

@rishabh-997
Copy link
Collaborator Author

@rishabh-997 Can you create a helper function to compare the equality of 2 VisitEntity objects? Like you did at #739 . It will make the code a lot easier and remove repetition.

yeah sure sir. will make it ready.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 looks good.

@f4ww4z f4ww4z merged commit 54c945a into openmrs:master May 18, 2020
@rishabh-997 rishabh-997 deleted the AC-758-visit branch May 19, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants