-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-758 Fixed VisitRoomDAO tests #738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 11.76% 11.76%
=======================================
Files 238 238
Lines 10646 10646
Branches 1027 1027
=======================================
Hits 1252 1252
Misses 9312 9312
Partials 82 82 Continue to review full report at Codecov.
|
LGTM :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 Can you create a helper function to compare the equality of 2 VisitEntity
objects? Like you did at #739 . It will make the code a lot easier and remove repetition.
yeah sure sir. will make it ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 looks good.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-758
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)