-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-740 fixed NPE at syncedPatient activity #734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a change
@f4ww4z please review!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuGO0 Thanks, just small changes and confirmation needed here.
...lient/src/main/java/org/openmrs/mobile/activities/syncedpatients/SyncedPatientsActivity.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/org/openmrs/mobile/activities/syncedpatients/SyncedPatientsActivity.java
Show resolved
Hide resolved
searchView takes up null value in dark mode of operation in absence of ActionBar,thus onCreateOptionsMenu never gets called
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 11.83% 11.78% -0.06%
==========================================
Files 237 238 +1
Lines 10569 10615 +46
Branches 1017 1022 +5
==========================================
Hits 1251 1251
- Misses 9237 9283 +46
Partials 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @LuGO0
@LuGO0 Add the ticket id to the commit message next time. |
Okay @f4ww4z Ill do that |
Description of what I changed
SearchView takes up null value in dark mode of operation in absence of ActionBar,thus onCreateOptionsMenu never gets called so NPE was thrown.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-740
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.