-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-746 NPE removed at Visit Dashboard #721
Conversation
@@ -554,7 +536,7 @@ | |||
"views": [], | |||
"setupQueries": [ | |||
"CREATE TABLE IF NOT EXISTS room_master_table (id INTEGER PRIMARY KEY,identity_hash TEXT)", | |||
"INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, \"f2ba83e78fa9d0190a4a24b5be11b2de\")" | |||
"INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, \"41a50b7fab10cb07ddedc8846a9b55f5\")" | |||
] | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 this file pops up with its modified version always when we build but I think you should keep this file out of this pull request as it is not directly related to this Issue !!
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 11.90% 11.90%
=======================================
Files 236 236
Lines 10502 10502
Branches 1006 1006
=======================================
Hits 1250 1250
Misses 9171 9171
Partials 81 81
Continue to review full report at Codecov.
|
removed changes in 1.json NPE removed at visit dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @rishabh-997
Description of what I changed
The error was because of a non-null variable in resource file which was being assigned null from the server, so changed it to accumulate null value.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-746
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)