Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-743 NPE removed at PatientDashboard #719

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

PatientDto was not excepting the null value for the photo which I changed so it can accept.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-743

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

Codecov Report

Merging #719 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   11.90%   11.90%           
=======================================
  Files         236      236           
  Lines       10502    10502           
  Branches     1006     1006           
=======================================
  Hits         1250     1250           
  Misses       9171     9171           
  Partials       81       81           
Impacted Files Coverage Δ
.../main/java/org/openmrs/mobile/models/PatientDto.kt 40.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1d450...456a61e. Read the comment docs.

@f4ww4z f4ww4z merged commit 114b011 into openmrs:master Apr 12, 2020
@rishabh-997 rishabh-997 deleted the AC-743 branch May 12, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants